Liens from the OLA review
Nov. 7, 2019

Participants:  Michael Aye, Kate Crombie, Mike Daly, Ray Espiritu, Peter James, Bea Mueller, Carol Neese, Eric Palmer.

Review meeting:  Oct. 10, 2019
Result of meeting:  The L2 calibration check was not yet fully completed as 
additional information was required.  All liens not related to the calibration
were compiled.
L2 calibration check completed:  Oct. 26, 2019.
Data certified:  Nov. 7th, 2019.
Liens finalized and review concluded:  Nov. 7, 2019

SIS
===

1.  Update Table 4 as needed to reflect current information.

2.  The SIS uses different nomenclature for the data processing levels than the names of the collections (raw, reduced, and calibrated).  Table 3 doesn't clear up this point as it doesn't mention which collection each processing level is in.  Include in an appropriate and obvious place in the SIS, probably Table 3, which collection each processing level is in.  Suggestion:  The column for NASA Product Level could be replaced by a column for the collection name.

3.  Section 4.2 refers to the "transaction ID" but doesn't specify the name of the attribute which holds this ID in the label.  Add this information.

4.  Section 5, "The following sections provide detailed data product specifications for each OLA L0 product."  Remove "L0".

5.  Correct data type mis-matches in the tables in Section 5.  (Detailed list in Michael Aye's review report.)

6.  Correct field name typos in the tables in Section 5.
	- parm_set_id --> param_set_id
	- patition --> partition
	- elevtion --> elevation

7.  The L0 ola_scan_time has been modified when going to the L1 ola_scan_time.  Document this change in the SIS.  (Duplicates lien #10.)

8.  Add Michael's parser for the ola_cal_file to the archive, probably as an appendix to the SIS.

9.  Add information to the SIS needed to carry out the OLA L2 calibration, listed in Michael Aye's final review report dated Oct. 31, 2019 (available on request to Carol Neese, neese@psi.edu).  

10.  It's currently not possible to match the L1 pulses up with the L0 pulses one-to-one.  In order to remedy this, add a formula to the SIS that states how pulses are removed from the L0 to the L1 product.  Document how the ola_scan_time is updated from L0 to L1. All pulses are in time order so the correlation between pulses can be made with updated documentation.

11.  Add an explanation to the SIS about the records with flag_status=3 being removed for L1.  Suggested text:  "During a scan, the OLA software injects fake timestamped records flagged with flag_status = 3.  These are removed during the L0 --> L1 processing.  The first record from each L0 file is also removed."


SCI Data and Labels
===================

12.  For Sci L1 product and label (and SIS), change flight software version field to be a version number instead of a change flag.


Bundle
======

13.  Correct LID references to LIDVID references in the bundle label.

14.  Remove extra spurious collection inventory from the data_reduced collection.


ola_cal_file
============

15.  Improvements to be made to ola_cal_file:

 - Add clarifying comments to the file, including order of the coefficients and other information that will help users understand the file.
 - duration_last_scan unit of measure is 1/100 of a second, resulting in conversion being off by a factor of 100.
 - The order of the coefficients should be explicitly labelled.
 - Correct inconsistencies in names between SIS and calibration file
 - The SoH conversions are at the very bottom of the document, making them hard to find.  Include a pointer to the information near the top of the document.
 - pos/plus and neg/minus are used interchangeably, and pos could be confused with position; clarify.
 - _x suffix is inconsistently added to calibrated values; either correct or clarify in document.


Planned timeline for resolving the liens:
=========================================

 - The next delivery, scheduled for Nov. 17, 2019, can be released prior to liens resolution as certified.  Liens 13-14 will be resolved on this delivery.
 - All remaining liens except #12 affect documentation only, specifically the SIS and calibration file.  The updated SIS and calibration file are planned to be delivered by Dec. 6th and can be released with the certified data.
 - Lien #12 affects the data labels and is planned to be resolved in time for the delivery due on Feb. 17, 2020.