Liens from the PDS Dawn VIR XM2 review
Mar. 26, 2019

Reviewers:  Ralph Milliken and Bethany Ehlmann (external) and Richard Chen (PDS Engineering Node).
Review finalized by email, Mar. 26, 2019
Result of review:  L1a volumes are certified.  L1b volumes are not certified, as the redelivered QQ files will have to be checked again by the reviewers.

To be fixed on all volumes
==========================

1.  */CATALOG/VIR_REF.CAT
- For CLARKETAL1984 and RUSSELLETAL2007, please move the year to the
end of their REFERENCE_DESC strings.

2.  AAREADME:  
 - Opposition  off-nadir scann mirror imaging - 7 obs  (scann --> scan)
 - Under File Formats, the last sentence in the second paragraph appears to have a word missing.  "...select (open?) and choose a text editor..."

3.  VIR_CALIBRATION_V2_9:  There is some highlighting on p10-11 of the pdf that should be removed in the final delivery.


VIR L1a
=======
DWNC6VIR_I1A
DWNC7VIR_I1A
DWNC8VIR_V1A

4.  DWNC6VIR_I1A/VOLDESC.CAT
- VOLUME_NAME exceeds 60 characters:
  "DAWN VIR RAW LEVEL-1A IR SPECTRA CERES EXTENDED 2 INTERMEDIATE"

5.  DWNC7VIR_V1A/DATA/20180118_CX2/VIR_VIS_1A_1_569519543_1.LBL
DWNC7VIR_V1B/DATA/20180118_CX2_HOLDING/VIR_VIS_1B_1_569519543_1.LBL
DWNC7VIR_V1B/DATA/20180118_CX2_HOLDING/VIR_VIS_1B_1_569519543_QQ_1.LBL
- The max allowed value for DAWN:VIR_VIS_START_Y_POSITION is 7, but these have:
  DAWN:VIR_VIS_START_Y_POSITION=96       


VIR IR L1b
=======
DWNC6VIR_I1B
DWNC7VIR_I1B

6.  The data in Cycle 5, Seg 1 are star calibrations.  This is specified in the target of the label and in the science observations table, but to make it even more clear we recommend giving the star calibration directories a special name such as STARCAL.  The L1a directories should be renamed accordingly.

7.  QQ files have a problem and cannot be read correctly.  Supply the corrected QQ files.

8.  DWNC6VIR_I1B/DATA/.../*LBL
DWNC7VIR_I1B/DATA/.../*LBL
- Keyword values should be all caps
  CORE_UNIT = "W/(m**2*sr*micron)"


VIR VIS L1b
===========
DWNC8VIR_V1B

9.  Checkout data don't appear to be documented in the SIS or calibration document, or it can't be found by searching on the word "checkout".  Add information to the SIS and/or calibration document so the checkout data can be understood, or if this is already done, include the word "checkout" so it can be found via search.

10.  QQ files have a problem and cannot be read correctly.  Supply the corrected QQ files.

11.  Add to the section of the data set cat describing the known data artifacts a line about the "hump" at 0.8 microns.  Suggested wording, something like "A feature of the spectra near 0.8 microns is under investigation at the time of delivery to determine whether it is real or an artifact."

12.  Confirm that the L1A files with no L1B are calibration or otherwise intended not to be processed.

13.  DWNC7VIR_V1B/DATA/20180118_CX2_HOLDING/VIR_VIS_1B_1_569519543_QQ_1.LBL
- The referenced file was not provided for the review: ^QUBE = "VIR_VIS_1B_1_569519543_QQ_1.QUB" .  More generally, confirm that all QQ files have been delivered, and supply any missing files.  

14.  Subfolder names in L1B volume should match those in the L1A volume.

15.  DWNC7VIR_V1A/VOLDESC.CAT
- VOLUME_NAME exceeds 60 characters:

16.  DWNC7VIR_V1A/DATA/20180118_CX2/VIR_VIS_1A_1_569519543_1.LBL
DWNC7VIR_V1B/DATA/20180118_CX2_HOLDING/VIR_VIS_1B_1_569519543_1.LBL
DWNC7VIR_V1B/DATA/20180118_CX2_HOLDING/VIR_VIS_1B_1_569519543_QQ_1.LBL
- The max allowed value for DAWN:VIR_VIS_START_Y_POSITION is 7, but these have:
  DAWN:VIR_VIS_START_Y_POSITION=96       

17.  DWNC7VIR_V1B/VOLDESC.CAT
- VOLUME_NAME exceeds 60 characters:
  "DAWN VIR CAL LEVEL-1B VIS SPECTRA CERES EXTENDED 2 ELLIPTICAL"

end of liens.