Liens from the review of the Dawn FC regional DTMs/Mosaics
Mar. 11, 2019

Reviewers:  Carolyn Ernst and Jason Perry (external) and Richard Chen (PDS EN).

The review was completed by email on Mar. 11, 2019.
Result of review:  The data set is certified.

Data and data labels
====================

1.  In the data label, move line_display_direction and
sample_display_direction keywords to inside the image object.

2.  The mosaics labels contain a note which should apply only to the DTMs and
should be removed from the mosaics labels:
/* NOTE:                                                                   */
/* Conversion from Digital Number to HEIGHT, i.e. elevation in meters, is: */
/* HEIGHT = (DN * SCALING_FACTOR).                                         */
/* The conversion from Digital Number to PLANETARY_RADIUS in meters is:    */
/* PLANETARY_RADIUS = (DN * SCALING_FACTOR) + OFFSET                       */
/* where OFFSET is the radius of the reference sphere.                     */

3.  DWNCLSPG_2/DATA/.../*.IMG
- A few lines in each header (added manually?) don't end in CRLF.
In DATA/DTM/CE_LAMO_L_AHUNAMONS_EQU_DTM.IMG, the lines are:
/* NOTE:                                                                   */
/* Conversion from Digital Number to HEIGHT, i.e. elevation in meters, is: */
/* HEIGHT = (DN * SCALING_FACTOR).                                         */
/* The conversion from Digital Number to PLANETARY_RADIUS in meters is:    */
/* PLANETARY_RADIUS = (DN * SCALING_FACTOR) + OFFSET                       */


Documents and catalog files
===========================

4.  DOCINFO.TXT:  There is a weird stray question mark in this file: "Text
files that list the L1A images from FC2 used in the SPG?Mosaic data
generation process."  

5.  DWNCLSPG_2/DOCUMENT/STEREOPHOTOGRAMMETRY/STEREOPHOTOGRAMMETRY.LBL
- Is this the correct DATA_SET_ID? EN has not seen it before
  DATA_SET_ID = "DAWN-A-FC2-5-VESTAHAMODTMSPG-V1.0"
In 2017.03, EN ingested 
  DATA_SET_ID = "DAWN-A-FC2-5-VESTADTMSPG-V1.0"

6.  DWNCLSPG_2/CATALOG/FC2_CERES_LAMO_DTM_SPG_DS.CAT 
- Line 52: extraneous " at end of line.


Browse
======

7.  DWNCLSPG_2/BROWSE/.../*.LBL
- All but two of the labels are missing their extensions, e.g.
  ^JPG_DOCUMENT = "CE_LAMO_L_AHUNAMONS_EQU_DTM"
should be
  ^JPG_DOCUMENT = "CE_LAMO_L_AHUNAMONS_EQU_DTM.JPG"


Index
=====

8.  DWNCLSPG_2/INDEX/INDEX.LBL
- Line 13: BYTES = 183 should be 193
- Line 32: BYTES = 35 should be 33
- Line 51: BYTES = 30 should be 31


EXTRAS
======

9.  Extrainfo.txt says "If the viewing software does not support this format,
the image will appear to be saturated."  But this does not correctly
describe the results reported by Carolyn when she tested them in a variety
of software.  Modify the language in extrainfo.txt to something like
"If the viewing software does not support this format, the image will
not be displayed correctly and may appear saturated, black, or corrupted."
It would also be helpful to give examples of programs which do display
the products correctly.

end of liens.